CohenArthur

Results 260 comments of CohenArthur

@mvvsmk take a look at `gcc/rust/expand/rust-macro-builtins.cc`. The tables at the top help understand the structure of builtin macro handlers, so for example for `include_str` we have the following entry: ```c++...

@braw-lee do you want some help on moving this to the typechecking phase?

@badumbatish some of them are more correct than others, and some of them are also nested - but yes, this is basically it :) it's quite a simple issue, I'll...

For reference this is the assert that fails: ```c++ template inline wi::storage_ref wi::int_traits < generic_wide_int >:: decompose (HOST_WIDE_INT *, unsigned int precision, const generic_wide_int &x) { gcc_checking_assert (precision == x.get_precision...

> > optional: Add [[nodiscard]] > > Isn't this C++17 ? Won't it break with 4.8 ? yeah, this does break it. I'll remove the commits. it's very useful for...

@matthewjasper I opened issues for all your comments, but I don't think I'll be addressing them in this PR as the goal for this one is to not add any...

amazing work on this @P-E-P, well done :)

thanks @Harshit933! this indeed reproduces the issue, are you interested in working on fixing it?

interesting, thanks :) this might be a name resolution issue