CohenArthur

Results 260 comments of CohenArthur

Clearing assignees since there hasn't been any activity on the PR and it's now closed. @54k1 if you still want to work on it feel free to ask to be...

> > LGTM! @liushuyu I think this is in a good state to merge now code-wise - I would just like some tests to make sure everything works well and...

Hey David, thank you for working on this. I think this is an extremly important step that we needed to get to at some point. I'm happy to see it...

> As we all know, my "soon" may easily expand into multiple weeks... ;'-\ Let's not put extra pressure on ourselves :DD We all appreciate the time and effort you...

> this implies lots of tedious work going through all the errors, adding the error codes. I was interested in the hack of being able to emit error codes, but...

@davidmalcolm I took the liberty of rebasing your changes and fixing the conflicts, as well as formatting the code. Feel free to delete these commits if you'd like to do...

I'm unsure as to whether this should live in our typechecker or our const checker. One one hand, it makes sense to check that during typechecking, on the other hand...

Thanks :D I think this is basically the same issue as #1084. Having macros as return values is not an issue, but having macro invocations as macro arguments does not...

Ah, that's really interesting. I'm investigating right now, thank you for the precisions :)