CohenArthur

Results 260 comments of CohenArthur

I agree :D However, I think that should come in much later - we might end up removing a lot from C++'s constexpr folder, or need extra stuff, etc. I...

@bjorn3 I think this is definitely why we need to investigate! I personally hadn't given any thought about const panics or about how vtable layouts would impact the constant evaluator....

The reason for this is actually a bit weird. `rustc` stores the content of blocks as a list of statements, while we keep a list of statements and a tail...

The temporary fix is to wrap the `unsafe` block within another block. I suspect we're just missing a call somewhere in the macro transcriber parser

The error comes from the multiple calls to `parse_stmt` in `transcribe_many_stmts`. Since `parse_stmt` directly calls `parse_vis_item` when seeing `UNSAFE` tokens, the parser does not understand unsafe blocks: Simply unsafe functions,...

As a side-note, I haven't been able to understand the new system which can emits errors based on locale. I'll have to ask on the Rust zulip for an explanation...

I found the error message but couldn't figure out the Diagnostic or how it was emitted. Thanks a lot @bjorn3 :DD

Since the goal is to dump valid rust code, we should also think of a way to test that we produce valid rust code. I think this might be something...

This is already done within the compiler and simply needs to cover more cases as with go

Seconded - Same on my project - OS: Linux, Archlinux distribution - Not using WSL - `fleet build` and `cargo build` - `.cargo/config.toml`: After running fleet, but empty otherwise ```toml...