Dr. Christian Tacke

Results 84 comments of Dr. Christian Tacke

@guitargeek should I rebase or something?

Rebased, so that the tests run against the latest version. Maybe it''s getting better?

I can add those comments to my PR. I am wondering, whether TNamed is the only affected class? If not, then this warning should be put in some central place...

So please suggest a concise wording for this PR and I will change it. I'd probably go for ```cpp TNamed() {} // your-wording ``` then.

> For the `TObject` documentation I would add something along the line of: > > ``` > Classes derived from `TObject` can not use the `= default` syntax for their...

> How does the move of `fCurrentTrack` from `FairStack` to `FairGenericStack` influence downstream projects, which (for example `class PndStack : public FairGenericStack`) also declare `fCurrentTrack`. Will all the project need...

First: I agree with Dennis. Note: I think, we added the error message there, because the new implementation effectively (using `unique_ptr`) `delete`s the passed in FairVolume. So this was some...

> > we added the error message > > If you mean recently, no, we did not add it. It was already there for decades. Ohhh, okay. Then: With the...

Before 7f0f7f185cbef80298aeedb368631d638c1782d6 the passed volume was not destructed (and leaked). So any user of `addVolume` could still continue using the FairVolume. With the destruction the error message became a little...

Please unstale. Something like this or #88020 would be appreciated.