Dr. Christian Tacke

Results 84 comments of Dr. Christian Tacke

I added #1551 to improve the logging of this. (I had this patch around for a while anyway. So a good opportunity to turn it into a PR). @karabowi and...

Next possible option: FairParSet seems to have a "static" mode: https://github.com/FairRootGroup/FairRoot/blob/32bb52f41d5945acf128dcb3c712fa91fe2b5103/fairroot/parbase/FairParSet.h#L63-L64 This completely disables running `init()` (and thus avoid the error completely by not even trying to initialize things): https://github.com/FairRootGroup/FairRoot/blob/32bb52f41d5945acf128dcb3c712fa91fe2b5103/fairroot/parbase/FairRuntimeDb.cxx#L545-L547...

After having thought about option (1) above, I consider it quite useful. There are some options: ```cpp struct PndEmcGeoPar : public FairParGenericSet { bool do_not_call_init_at_all{false}; //! bool ignore_errors_from_init{false}; //! bool...

#1551 improves the situation by moving the error out of `init()` to the caller of `init()`. So if it returns true (by overriding it), then no error will be printed....

> @karabowi reopned this If you wanted to rerun the CI due to the errors: - Please rebase to latest dev. It has a bunch of fixes that affect the...

> FairRunSim runs the simulation initialization in SetMCConfig() function, which: > … Can we document exactly this somewhere, please? Maybe on FairRunSim and/or FairMCApplication?

Hi @karabowi, https://github.com/FairRootGroup/FairRoot/blob/6decd1eeb31aba0aa2c196e19b4acafe6f76e854/fairroot/base/sink/FairRootFileSink.cxx#L249-L250 do you want to remove this? Or keep it for backward compatibility?

> Change log level for multiple sensitive volumes with same name > > Both the transport engines and FairRoot allow registering of multiple nodes with the same volume/same volume name...

Can you extract the chore / deprecate part into its own PR? I like those and would like to get them finished and merged first.

After having thought about this whole thing a bit (see ), I doubt that we actually should have yet another knob. (Yes, I proposed the knob thing, please excuse!) Not...