Dr. Christian Tacke
Dr. Christian Tacke
An interesting question from this morning: Should callers of GetObject be able to modify the object they get this way? If not, then GetObject maybe should return a `const TObject*`?
I guess GetObject could return a nullptr, if the thing isn't found? What we need is something like a unique_ptr, just with no ownership semantics. In theory we could use...
Right, AbsorbObjects modifies fInputArray. So no const there.
@hnatics, For a discussion related to `GetTreeName` / `GetFolderName`, please take a look at #1111 and continue there.
See also: - https://github.com/FairRootGroup/FairMQ/pull/478/checks - #478 - #479 Dennis and I are in tight contact regarding the version field. This one is not as simple as it seems. I even...
> Just collecting what shows up so far: > > ``` > Common/Field/src/MagFieldFact.cxx:30:73: warning: 'FairFieldFactory::fCreator' is deprecated [-Wdeprecated-declarations] > 30 | MagFieldFact::MagFieldFact() : FairFieldFactory(), mFieldPar(nullptr) { fCreator = this; }...
I think, this might be duplicate of #1108? I added a note there.
We fixed this in dev: ac9dba598eb911b7bc344b16a0231dd7266990bd It was backported to 18.8: f9f1648108e58ca998cd0b8a0d67601440934ad0 And to 18.6_patches: f6928ee732e1a52527ca30ea4f442c44699c5523 Does this all fix this issue?
Just to link the PR: #1150
@YanzhaoW: This should fix the second part of #1418. Could you take a look?