root icon indicating copy to clipboard operation
root copied to clipboard

[core] Pass TString by value to TNamed ctor

Open ChristianTackeGSI opened this issue 3 months ago • 1 comments

This Pull request:

Passing by const-reference can mean two constructions (once on the caller, once in the ctor using the TString copy ctor).

Instead passing by value and using move semantics in the ctor can reduce this to one construction on the caller and one move in the ctor.

Checklist:

  • [X] tested changes locally
  • [ ] updated the docs (if necessary)

fixes: #15434

ChristianTackeGSI avatar May 09 '24 12:05 ChristianTackeGSI

Test Results

     9 files       9 suites   1d 20h 9m 57s :stopwatch:  2 635 tests  2 625 :white_check_mark: 0 :zzz: 10 :x: 22 356 runs  22 308 :white_check_mark: 0 :zzz: 48 :x:

For more details on these failures, see this check.

Results for commit 03038d22.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 14:05 github-actions[bot]