Dr. Christian Tacke

> @ChristianTackeGSI Something wrong in CI? > > I got an error saying cmake version is too old in CI machine. > > > CMake Error at CMakeLists.txt:8 (cmake_minimum_required): >...

Hi @YanzhaoW, are you using FairLmdSource? If so, could you take a look at #1465?

Many thanks for taking a look! :-) We can't call `Close` directly from the destructor. Calling a virtual member function from a constructor doesn't do what you would expect. So...

@fuhlig1 Could you add this double-calling-prevention assert to some of the FairRoot tests/examples please? Maybe open it in a new PR, so that we get this test before we merge...

We noticed in this morning's meeting, that we should consider raising the minimum required geant3 version to the one containing some fixes relevant to this pull request. If we do...

Also before we merge this one, we probably should do a rebase/cleanup of the commits. And before we merge it, we should get clear on our release planning (this currently...

Hi @fuhlig1 could you consider adding a compile check for the macro like in #1421?

The centos 7 CI tests fail, because they don't have yaml-cpp installed. As Dennis already pointed out, we should get clear on how this should be handled?

Next step: Memory management. If SetSimulationConfig gets an owning pointer (as all the proposed examples do), FairRunSim should clean up that memory. My proposal would be to perform the same...

Please also add the `cherry-pick -x` style lines, if appropriate.