Christian Murphy comments

Results 263 comments of


                                            Christian Murphy

Use estraverse for visiting AST

@ideadapt would you be interested in opening a pull request to refactor to `estraverse`?

translation error

Good catch @kaktus42, would you be interested in opening a [pull request](https://help.github.com/articles/about-pull-requests/)?

fix(deps): update dependency org.apereo.service.persondir:person-directory-api to v1.8.16

Thanks for checking on that @jgribonvald! Yes, probably something we'll want to test manually.

feat: Add appropriate entities to showcase modal notifications

@bjagg is Jasig/NotificationPortlet#114 still on the roadmap?

Troubleshoot effects of the ESUP file-manager on the portal page

@drewwills @jgribonvald was this resolved in #176 ?

Update Tomcat Zip, Tar, Docker tasks to exclude unneeded webapps/directories

Part of the logic from, https://github.com/Jasig/uPortal-start/blob/262c4096cca4abfb6c8847a880fbae4d88542b6b/gradle/tasks/tomcat.gradle#L166-L183 could be reused.

Fix relative paths in Gradle tasks

@bjagg what environment did you encounter this issue on? Are there additional steps to reproduce the issue? CI is running `./gradlew tomcatInstall` across a few platforms and doesn't appear to...

"list your deployment of uPortal alongside the many others already registered" link is broken

Question @apetro and @drewwills, Who for uPortal, or in general, has access to update the Apereo website?

"list your deployment of uPortal alongside the many others already registered" link is broken

It bugs me how much effort it takes to get small changes into the Apereo site. I'm starting a GitHub pages based redesign that can (hopefully) replace the existing site....

feat: deploying esco-hamburger-menu from quickstart

related to #220