esgraph icon indicating copy to clipboard operation
esgraph copied to clipboard

Use estraverse for visiting AST

Open ideadapt opened this issue 9 years ago • 3 comments

Hi

What do you think about using estraverse (https://github.com/estools/estraverse) ? I see that you are using your own module walkes. Maybe we change walkes to use estraverse, or directly replace walkes with estraverse. I'd prefer the latter.

ideadapt avatar Mar 31 '15 15:03 ideadapt

Back in the day when I wrote this, I just needed the simplest possible thing. estraverse was just too large for my use cases.

But I dont really use or maintain either today. So if you want you can just take over maintainership completely :-)

Swatinem avatar Mar 31 '15 15:03 Swatinem

@ideadapt would you be interested in opening a pull request to refactor to estraverse?

ChristianMurphy avatar Nov 13 '17 16:11 ChristianMurphy

@ChristianMurphy Interest may be there, but for now my focus is not on this. Having other stuff going on now that absorbs my time.

ideadapt avatar Nov 20 '17 17:11 ideadapt