uPortal-start icon indicating copy to clipboard operation
uPortal-start copied to clipboard

feat: deploying esco-hamburger-menu from quickstart

Open jgribonvald opened this issue 7 years ago • 5 comments

Checklist
Description of change

Here is a commit on how to deploy the esco-content-menu.

How would you like to include it ? Adding only a documentation into esco-content-menu wc ? or like that ? After I'm agree the script into the jsp invoker can be reviewed, but I did like that as I wasn't able to deploy it with the menu button component, I need to generate the button directly into the body and adding an event javascript to open/hidde the page.

So this commit is in WIP more for a feedback ! (And is independent of solving font issues)

jgribonvald avatar Oct 18 '18 13:10 jgribonvald

related to #220

ChristianMurphy avatar Oct 18 '18 15:10 ChristianMurphy

I think that I can't improve more things inside this PR, or tell me what do do ! (I shown how it was easy to deploy it !) So you have the rigth to close this PR, or ??? it's one way of moving from the good old one Menu, but a part is missing: the accessibility check ;)

jgribonvald avatar Jan 30 '19 21:01 jgribonvald

@jgribonvald -- I'm very interested in getting the ESCO Hamburger into quickstart.

This week is pretty busy, so it's hard to look, but I do think this is a good idea.

drewwills avatar Jan 31 '19 15:01 drewwills

As example a quick and fast way to change the welcome page:

  • you can use this same commit
  • modify the jsp in this commit with a such code (adapt properties like you want/need)
<esco-content-menu
      default-org-logo="${alternativeBanner[0]}"
      favorites-portlet-card-size="${favoritesPortletCardSize[0]}"
      grid-portlet-card-size="${gridPortletCardSize[0]}"
      hide-action-mode="${hideActionMode[0]}"
      portlet-api-url="${portletApiUrl[0]}"
      layout-api-url="${layoutApiUrl[0]}"
      organization-api-url="${organizationApiUrl[0]}"
      user-info-api-url="${userInfoApiUrl[0]}"
      :show-favorites-in-slider="false"
      debug>
      <div slot="header-buttons"></div>
      <div slot="content-user"></div>
    </esco-content-menu>
</div>

<script type="text/javascript">
  document.addEventListener("DOMContentLoaded", function(event) {
    const parent = document.getElementById("portalPageBody");
    while (parent.firstChild) {
      parent.firstChild.remove();
    }
    parent.appendChild(document.querySelector('#content-menu'));
  });
</script>

and you will be able to get a such portal content: image

jgribonvald avatar Apr 17 '19 12:04 jgribonvald

I've modified:

  • the jsp to make optional to hide the native uPortal Nav from preference portlet property hidePortalNav
  • changed the admin-dashboard to evoid to load several times the esco-content-menu lib and vuejs lib too as it's integrated from the esco-content-menu jsp on each page

I think if we want to integrate it, it can be done now. Maybe some change should be done on the hamburger menu for Accessibility. Any help would be welcome on this part.

jgribonvald avatar Jun 06 '21 11:06 jgribonvald