uPortal-Project
Troubleshoot effects of the ESUP file-manager on the portal page
The ESUP file-manager is now on the Welcome tab (quickstart data set) by default.
It's a great addition, but I detect 3 new regressions when the portlet is present:
- [x] The 'Options' menu does not appear. There is a JavaScript error relating to the Portlet Print option that doesn't allow the Options menu to finish bootstrapping. (Odds are goo the Portlet Print feature is no longer working properly.)
- [x] The user cannot access the right-click menu on the page.
- [ ] CSS from the file-manager is changing the appearance of the Calendar portlet (others?)
-
For the print option In my mind the print option should be removed ! We made the choice to remove it from our feature as it's difficult to maintain it with different kind of portlets and with their content. On an other way users don't use it a lot or don't understand why they can't have this options on some case. It's a frustration. Also we should work on mediaqueries to define specifics print css, but it's too much to do ! As the last word I don't know if someone use again this feature (introduced by me for the ESUP context and don't work since uP 4.x) !
-
For the right click Woooh good catch ! Nobody seen this "bug", In my mind the problem is here : https://github.com/uPortal-contrib/esup-filemanager/blob/master/src/main/webapp/js/esup-stock.js#L1649
-
For the CSS changing CalendarPortlet This is due to the JqueryUI lib embedded into Esup-Filemanager. It make a long time that I say to myself that we should extract js libraries into the skin.xml feature, but i didn't have time for that.
In my mind an issue should be created into https://github.com/uPortal-contrib/esup-filemanager/issues for these 2 last problems
I agree the print option should be removed from uPortal. It never was much used, and if we needed it now (in 2018) I bet there would be a much better way to do it.
@ChristianMurphy & @jgribonvald,
Only this sub-issue remains...
CSS from the file-manager is changing the appearance of the Calendar portlet (others?)
It would be good to fix it.
For tracking, we could close this ticket and open a new, smaller ticket.
@drewwills : to fix the problem we have to watch on jquery-theme and jquery version.
- first change may be that ESUP-FileManager need to follow uPortal jQuery version
- the main problem is on the jquery theme used, there isn't theme context limited to ESUP-Filemanager - I never encountered a such problem so I don't know if this can be solved by configuration. Do you know more about that ?
- Maybe the solution is only on defining the loading of jquery by context, but problems should come from here on this page