Christian Murphy

Results 263 comments of Christian Murphy

An interesting idea @jgribonvald :thinking: How do you see this fitting with existing solutions like webproxy portlet and jsp pages? Would this be preferred over those? Or is there a...

That'd be great! Would you be interested in opening a PR for that @bjagg ?

This appears to be related to [Simple Content Portlet breaking](https://groups.google.com/a/apereo.org/g/uportal-user/c/MwGUzv4vG7w). The long term fix is https://github.com/uPortal-Project/SimpleContentPortlet/pull/397. The [post in Google groups](https://groups.google.com/a/apereo.org/g/uportal-user/c/MwGUzv4vG7w) describes a work around until the long term fix...

Hey @jgribonvald! :wave: Rest assured this PR has not been forgotten. :relieved: Many of the uPortal committers are focused on preparation for [Open Apereo 2018](https://www.apereo.org/conferences/open-apereo-2018) right now. :soon: More folks...

Hey @jgribonvald! :wave: Can you help me understand your intended use case for this change? When should uPortal and the portlets be put outside the server context?

Thanks Julien! The more I hear this described the more I think there may potentially be overlap with existing tomcat tasks, particularly `tomcatDeploy`. What I'm trying to understand is: *...

Hey @fwx5618177! 👋 Thanks for sharing. General feedback on what gets included in the plugins list: > Some criteria to include packages in this list. > > - Some documentation...

At a high level, it looks like this plugin aims to work on HTML? If so it may make sense as a `rehype` plugin instead, where is can work more...

Welcome @Chailotl! Thanks for sharing! > The `` tag already works with any video extension. The `` tag does, this plugin currently only works for MP4. https://github.com/Chailotl/remark-videos/blob/851c332993210e6f091453f7ed887be24492bcee/index.js#L7 There are a...

No worries! Some other ideas: 1. consider adding more automation like: 1. adding some test cases with `node:test` to make it easier to confirm the plugin works and easier for...