Chris Dodd
Chris Dodd
I eventually "fixed" it by installing/enabling the ssh-server package -- apparently the agent only works properly if the server is installed? Would be nice if the agent could work on...
Localcopyprop currently does not copyprop list expressions (deliberately). The code from localcopyprop.cpp:323 if (as->right->is()) { /* FIXME -- List Expressions need to be turned into constructor calls before * we...
Does ir make sense to use the existing `inout` direction rather than introducing a new `rmw` keyword? This sort-of fits with the idea that "directionless" parameters are implicitly `in` in...
This should be unnecessary -- code should never create distinct instances of IR::Type::Boolean. The original design of the IR was to have all IR::Type objects be pointer-comparable -- there should...
> True, but it can easily happen and lead to errors like this. This PR just makes LOr and LAnd consistent to how `Operation_Relation` is initialized. I'm a little hesitant...
> I guess (@ChrisDodd would maybe know as he was probably there when this was designed) this is not problem by itself, as the IR is not typed correctly until...
> I'd like to push back on the unconditional part a bit. I can see cases where downstream projects may want to supply their own types to a particular node....
> When I was looking at the `Operation_Relation` constructor after it was generated it looked like this: > > ```c++ > IR::Operation_Relation::Operation_Relation(const IR::Type* type, const IR::Expression* left, const IR::Expression* right)...
The spec doesn't really say what a brace enclosed list by itself is, so allowing it to be implicitly converted to a tuple or a struct or a header type,...
I added an extra commit with the IR changes for this.