Chris Dodd

Usually the TCP checksum is calculated by differential over the header, without looking at the payload -- compute the checksum over the incoming headers (assuming the checksum there is correct)...

According to [8.11.2](https://p4.org/p4-spec/docs/p4-16-working-draft.html#sec-implicit-casts) in the spec, serializable enums may be implicitly converted to their underlying type, so this code probably needs to deal with that case too.

I think there's a concern that allowing "loops" in possible implicit cast types could lead to issues when resolving overloading and typechecking, so if an implicit cast A -> B...

> In some future revision of P4, we might consider a different approach, where unsized constants are of _generic integral type_ instead of `int` That is supposed to be what...

Looking at the discussion in https://github.com/p4lang/p4c/issues/2444, it seems that it was decided to add implicit conversions from `int/bit` to `int`, in a limited way (so as to still disallow `int`...

There's a one-line comment from Mihai that "perhaps that should be allowed", and that it would be added to the discussions for the LDWG. Unfortunately, it looks like note from...

> . Therefore, it is possible to modify the objects by iterators (e.g. exchange them), without modifying the map. Example could be using `std::remove_if` on an indexed vector. Is that...

I think there's a place for both. - ir/README.md should have a *short* description of concept of .def files and the ir-generator tool that generates C++ code from them, as...

(sorry I missed this PR when it first came around) How do we get IR::Vectors with duplicate nodes in them? In all the cases where you're calling `visit_unique_children` it would...

> @fruffy I was hoping for something that'd allow me to just pass `--top4 RemoveDontcareArgs` to the compiler and view the generated IR. Well, you can just run the .test...