Chris Dodd

In general, passes should preserve annotations on blocks, which inhibits some cases where blocks could be combined. In my PR I fixed a number of cases where annotations were inadvertently...

> > Having an extern (similar to gcc's `__builtin_expect`) on the other hand would potentially inhibit some optimizations... Having an extern means that backends that don't care will need to...

I thought we already required a certain minimum version of boost? Newer than what is installed by default on some versions of Ubuntu. We should probably just bump that up...

One issue I noticed with the PDF version (also present in the html but less noticeable) is that it appears to be using a larger font for the code example...

The explicit filename/line stuff used by the json parser is broken and useless, as it is never read by anyone, except when redumping json. It should be removed and replaced...

p4c PR in https://github.com/p4lang/p4c/pull/5115

One observations is that arrays of externs make a lot of sense -- so much so that externs like `Counter`, `Meter`, and `Register` have them already embedded. With general arrays,...

> It seems like a good idea to have a test case that has side effects in the l-value, I added this in a second testcase, as well as pulling...

> The P4Testgen failures are because of crashes in BMv2. It is possible that the generated JSON is invalid. The .stf test I wrote by hand works fine, so BMv2...

> > The P4Testgen failures are because of crashes in BMv2. It is possible that the generated JSON is invalid. Looking more closely, the problem is due to indexing a...