Chris Dodd
Chris Dodd
What is the cost of all these "unnecessary" cstrings? Yes an extra copy occurs when creating one, but that would happen with a `std::string` too. Yes, they are (currently) not...
The language does not define or enforce any naming conventions for P4, other than reserving names containing `__` for compiler/architecture internals. If someone wants a convention for P4 programs, IMO...
> With type you mean a typedef? typedef or nested struct
> Are the changes here merged into #4562? Can this be closed? There were minor syntax changes (`for` instead of a new `foreach` keyword), but I believe this can be...
Lots of points here > For some reasons these maps are wrapped into shared_ptr's, though I do not see where they are copied. This comes from flow_clone/flow_merge which clone the...
> loop_revisit and corresponding boilerplate This is actually still work in progress, to allow some ability to deal with IR loops in visitors. But as it is, it is very...
I've been experimenting a bit with this and another implementation issue I see is that it does not appear to be possible to stop specific warnings with explicit casts --...
> I think it would make sense to use GC just as opt-in for certain classes/places, for example the IR::Node-derived once, but not for _everything_. The current state with replaced...
There's a fair amount of code that uses `cstring` as kind of an `optional` -- that is, it might be a string (which can't be changed) or might be a...
I plan to look into this, but it is a bit down on my todo list.