Cheerfulbull

Results 7 comments of Cheerfulbull

Creature separation window, add more vertical spacing between the small number buttons and the "OKAY" and "CANCEL" buttons

Hello @Branikolog , I have fixed the padding to make it more even. I was unable to replicate the visual glitch you sent. As for they grey highlighting (It's gold...

Creature separation window, add more vertical spacing between the small number buttons and the "OKAY" and "CANCEL" buttons

Also I don’t know why the MacOS check failed, seems to be a bug

Creature separation window, add more vertical spacing between the small number buttons and the "OKAY" and "CANCEL" buttons

That was a mistake, I thought that was one of the positioning / window size functions.

Creating save map dialog

Your code doesn't meet the style check first of all. Check [https://github.com/ihhub/fheroes2/actions/runs/8636671472/job/23677109018?pr=8564](https://github.com/ihhub/fheroes2/actions/runs/8636671472/job/23677109018?pr=8564) It gives you the following suggestion: ``` fheroes2::GameMode EditorInterface::eventSaveMap() - { - return Dialog::YES - == fheroes2::showStandardTextMessage( "",...

Share artifacts, army, exchange castle/town

Another idea is to share the Obelisk puzzle reveal, the way map discoveries are shared.

Rework `Battle::Unit::CalculateSpellDamage()` method to use `fheroes2::getSpellDamage()` and `fheroes2::getMonsterData()` functions

Hello, I was wondering why the `fheroes2::getSpellDamage()` takes into account spell caster artefacts but not spell victim artefacts. Is that part of this issue, or should a separate issue be...

Minor chest dialog changes

> Hi @Cheerfulbull I suggest we limit the scope of this PR to #9025 and create a separate PR for #9024. The idea with the phrase "XP needed:" is questionable...