ihhub
Creature separation window, add more vertical spacing between the small number buttons and the "OKAY" and "CANCEL" buttons
Made to address issue #7925. This increases the spacing between the Okay / Cancel buttons and the small numbers.
I understand that the editor is currently priority, so feel free to disregard this, but I thought this was a fairly easy issue, so might as well fix it.
Hi, @Cheerfulbull ! I've checked the PR and have a few comments. First of all, fast split icons highlighting is grey now. Is this change intentional? Previously, it had a red glowing effect.
I also feel, that the space between fast split icons and buttons line is a bit too large. I suggest making it the same, as between those split icons and the text above them.
Not sure, if it's related to the PR, but frame decoration looks not well in this area.
If the window would be improved, then some more space between the arrows (up/down) and the Min/Max buttonw would be welcome because it's rather tight on a touch device.
Hi, @Mr-Bajs
If the window would be improved, then some more space between the arrows (up/down) and the Min/Max buttonw would be welcome because it's rather tight on a touch device.
Indeed. But I believe it's out of the scope of this PR. I believe there could be created a separate set of issues, dedicated increasing the convenience using touch screens. We have dozens of places, where the original UI appears to be too small for touch devices. Some windows require even a complete rework in my opinion.
Hello @Branikolog , I have fixed the padding to make it more even. I was unable to replicate the visual glitch you sent. As for they grey highlighting (It's gold now for some reason?) I'm not sure what's causing that.
Hi, @ihhub Unfortunately, I cannot download compiled build for this PR now. The list does not appear on the page. I made some testing 1-2 weeks ago and highlight colour was still an issue unless something was changed in the last couple of days. I believe red colour is more perceptible for this UI element.
Hi, @ihhub !
Yellow selection frame is still the case. It is supposed to be red.
Also, there're still tiny defects on a frame which is automatically stretched according to the required size.
I suppose it is a flaw of our frame-generating algorithm which cuts decoration on the frame.
Hi @Branikolog , I reverted back color changes.
@Cheerfulbull , can you please explain why you changed colors?
That was a mistake, I thought that was one of the positioning / window size functions.