fheroes2 icon indicating copy to clipboard operation
fheroes2 copied to clipboard

Creating save map dialog

Open Stisen1 opened this issue 1 year ago • 2 comments

This is how far I've got

The game crashes when trying to save

Help is needed!

Stisen1 avatar Apr 10 '24 19:04 Stisen1

Your code doesn't meet the style check first of all. Check https://github.com/ihhub/fheroes2/actions/runs/8636671472/job/23677109018?pr=8564 It gives you the following suggestion:

fheroes2::GameMode EditorInterface::eventSaveMap()
-    {   
-       return Dialog::YES
-                       == fheroes2::showStandardTextMessage( "", _( "Are you sure you want to BREAK THE GAME?)" ),
-                                                             Dialog::YES | Dialog::NO )
+    {
+        return Dialog::YES == fheroes2::showStandardTextMessage( "", _( "Are you sure you want to BREAK THE GAME?)" ), Dialog::YES | Dialog::NO )
                    ? fheroes2::GameMode::WORLD_SAVE_GAME
                    : fheroes2::GameMode::CANCEL;
     }
-    
+

Cheerfulbull avatar Apr 12 '24 07:04 Cheerfulbull

I'm converting this pull request into a draft as it is not ready for review.

ihhub avatar Apr 13 '24 04:04 ihhub

I am closing this pull request as we implemented it.

ihhub avatar May 16 '24 15:05 ihhub