eventing
eventing copied to clipboard
Add attribute filter transform function
Fixes #7685
Proposed Changes
- Add a transform function for an attributes filter
- Use the transform function depending on the filter on the trigger in the constructor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Cali0707
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Cali0707]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/cc @Leo6Leo @pierDipi @creydr
This is just WIP until I add unit tests (probably tomorrow), so the actual changes are ready for a review!
Codecov Report
Attention: Patch coverage is 92.72727%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 69.49%. Comparing base (
7e1c082
) to head (c0a7e97
). Report is 46 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
pkg/graph/constructor.go | 84.61% | 1 Missing and 1 partial :warning: |
pkg/graph/transforms.go | 95.23% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #7909 +/- ##
==========================================
+ Coverage 69.22% 69.49% +0.27%
==========================================
Files 339 344 +5
Lines 19494 15943 -3551
==========================================
- Hits 13494 11079 -2415
+ Misses 5337 4187 -1150
- Partials 663 677 +14
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
rbac.go:40: an error on the server ("Internal Server Error: \"/apis/rbac.authorization.k8s.io/v1/namespaces/test-ngogqfqt/rolebindings/subscriber-walrgdtq\": the server is currently unable to handle the request") has prevented the request from succeeding
Looks like GKE issues
/retest-required
/cc @Leo6Leo @creydr @pierDipi
This is ready for review now
/cc @Leo6Leo
/test upgrade-tests
/lgtm
Whoops @pierDipi looks like this somehow got merged before I could address your feedback. I'll open a follow up PR later today to try and make the changes you asked for