Ruben Bridgewater comments

Results 323 comments of


                                            Ruben Bridgewater

tty: improve color terminal color detection

@nodejs/tty PTAL

Node.js Collaborator Spotlight Proposal

I like the idea and the form is LGTM. What we might want to do in addition is to highlight all new contributors a bit stronger.

all non-0 gRPC status codes being treated as errors

Hey @alexkb @constantineZum, thank you for the request! This got fixed in https://github.com/DataDog/dd-trace-js/pull/4800 I am going to close this therefore. If you find anything else that could be improved, please...

docs: generate list of all commands into readme #1313

This is a pretty huge list and takes a lot of space. I think moving this into a separate doc and adding a link to that would be best. I...

src: improve TextEncoder encodeInto performance

@anonrig even if the benchmark is not hitting the fast path: the benchmarks currently show a regression. I am surprised that is the case. Is there a possibility to prevent...

[nodejs] Rename dd-trace-js main branch

@cbeauchesne thank you, I had a old checkout. I rebased with latest main and fixed it.

pull agent image instead of rebuilding

@rochdev is this something you would like to still look into? I do think it makes sense to not have to built the agent on our own, but I didn't...

pull agent image instead of rebuilding

Thanks for the update @cbeauchesne! With that in mind, I'll go ahead and close this as it seems to not be an issue with the current setup. Please feel free...

Refactor tracer config option processing

This is quite outdated and as part of our configuration OKRs we'll also work on config.js again to improve that. I'll go ahead and close this for now. Please feel...

[DI] Record thread paused telemetry when breakpoint is hit

@watson yes, just updated the typo