Ruben Bridgewater comments

Results 323 comments of


                                            Ruben Bridgewater

readFile will not read files larger than 2 GiB even if buffers can be larger

Thinking about this again: we should probably not encourage people to read files into memory as a whole. Using multiple reads would prevent them from switching to streams, causing memory...

util: inspect: do not crash on an Error stack pointing to itself

@SamVerschueren instead of only returning the ErrorPrototypeToString call result, we could add additional information that the stack is circular similar to the other circular outputs.

util: inspect: do not crash on an Error stack pointing to itself

@SamVerschueren could you take another look? :) We could also land this as intermediate improvement and have another PR on top, I just thought it makes sense to combine the...

util: inspect: do not crash on an Error stack pointing to itself

Ping @SamVerschueren

remove shimmer.unwrap and shimmer.massUnwrap

Closing due to already being removed

[BUG]: `trace.koa.request.*` metrics are missing

Could you please reach out to our support https://www.datadoghq.com/support to ask for looking into this? We can't really provide support through github and they might be able to help you.

Change config.url to be a string instead of a URL object

@watson do you think you find some time to have another look at this? :)

Change config.url to be a string instead of a URL object

@watson I guess we could table this for now?

Change config.url to be a string instead of a URL object

Since there is a newer draft that does this in a more complete way, I'll close this as superseded. Please reopen, if that is not correct.

Add new ESLint plugin: @datadog/eslint-plugin

I do believe it would be good to have a datadog scoped eslint package, while it likely won't contain many rules for now. Is it something we should continue to...