dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

Refactor tracer config option processing

Open watson opened this issue 1 year ago • 5 comments
trafficstars

watson avatar Jul 17 '24 10:07 watson

Overall package size

Self size: 6.86 MB Deduped: 58.81 MB No deduping: 59.09 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.0.0 | 11.14 MB | 11.15 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 7.01 MB | | @datadog/native-iast-rewriter | 2.3.1 | 2.15 MB | 2.24 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Jul 17 '24 10:07 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-07-23 06:56:54

Comparing candidate commit 20a54f7d2b4785cbd6eb9d67758622e09a07cc80 in PR branch watson/DEBUG-2567/config-option-refactor with baseline commit d2c0b2cb644d72f2c5689c0a8dd49101b66819d2 in branch watson/DEBUG-2567/config-hidden-props.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

pr-commenter[bot] avatar Jul 17 '24 10:07 pr-commenter[bot]

Library Vulnerabilities

:white_check_mark: No library vulnerabilities found (scanned a37a3d6).

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.95%. Comparing base (0e69d6d) to head (71118ce).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           watson/DEBUG-2567/config-hidden-props    #4520       +/-   ##
==========================================================================
+ Coverage                                  17.65%   59.95%   +42.29%     
==========================================================================
  Files                                          6      253      +247     
  Lines                                        776    11399    +10623     
  Branches                                      33       33               
==========================================================================
+ Hits                                         137     6834     +6697     
- Misses                                       639     4565     +3926     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 19 '24 12:07 codecov[bot]

  • #4520 Graphite 👈
  • #4521 Graphite: 1 other dependent PR (#4492 Graphite)
  • #4515 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @watson and the rest of your teammates on Graphite Graphite

watson avatar Jul 19 '24 13:07 watson

This is quite outdated and as part of our configuration OKRs we'll also work on config.js again to improve that. I'll go ahead and close this for now. Please feel free to reopen, in case you believe that's a mistake!

BridgeAR avatar May 28 '25 23:05 BridgeAR