dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard
verified publisher icon DataDog

all non-0 gRPC status codes being treated as errors

Open alexkb opened this issue 1 year ago • 1 comments

Ever since v4.3.0 which received this update #3230 it seems all non-0 gRPC status codes are being reported as errors in datadog when they should be not. e.g. NOT_FOUND (5) or INVALID_ARGUMENT (3) are acceptable responses which are not errors.

I found that in the java version of dd-trace they allow you to configure the grpc plugin error statuses. Perhaps we need something like that.

alexkb avatar May 31 '24 08:05 alexkb

Hey, I noticed this issue is still open, and it’s also impacting us. I wanted to see if there are any updates or if additional details from our side would help. Appreciate your time and effort—let me know if we can assist in any way. Thanks!

constantineZum avatar Oct 14 '24 21:10 constantineZum

Hey @alexkb @constantineZum, thank you for the request! This got fixed in https://github.com/DataDog/dd-trace-js/pull/4800

I am going to close this therefore. If you find anything else that could be improved, please open a new issue :)

BridgeAR avatar Mar 04 '25 00:03 BridgeAR