dd-trace-js
dd-trace-js copied to clipboard
DataDog
pull agent image instead of rebuilding
What does this PR do?
Pull agent image instead of rebuilding.
Motivation
The agent can only change in the system tests repo, so there is no reason to keep rebuilding it on every commit.
Overall package size
Self size: 6.82 MB Deduped: 58.31 MB No deduping: 58.59 MB
Dependency sizes
| name | version | self size | total size |
|---|---|---|---|
| @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB |
| @datadog/native-iast-taint-tracking | 3.0.0 | 11.14 MB | 11.15 MB |
| @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB |
| protobufjs | 7.2.5 | 2.77 MB | 6.56 MB |
| @datadog/native-iast-rewriter | 2.3.1 | 2.15 MB | 2.24 MB |
| @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB |
| @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB |
| @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB |
| import-in-the-middle | 1.8.1 | 71.67 kB | 741.34 kB |
| msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB |
| opentracing | 0.14.7 | 194.81 kB | 194.81 kB |
| semver | 7.5.4 | 93.4 kB | 123.8 kB |
| pprof-format | 2.1.0 | 111.69 kB | 111.69 kB |
| @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB |
| lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB |
| lru-cache | 7.14.0 | 74.95 kB | 74.95 kB |
| ignore | 5.2.4 | 51.22 kB | 51.22 kB |
| int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB |
| shell-quote | 1.8.1 | 44.96 kB | 44.96 kB |
| istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB |
| tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB |
| limiter | 1.1.5 | 23.17 kB | 23.17 kB |
| dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB |
| retry | 0.13.1 | 18.85 kB | 18.85 kB |
| jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB |
| crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB |
| path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB |
| koalas | 1.0.2 | 6.47 kB | 6.47 kB |
| module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |
🤖 This report was automatically generated by heaviest-objects-in-the-universe
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Benchmarks
Benchmark execution time: 2024-07-05 19:54:50
Comparing candidate commit c40480d7aaf63734c32941f6166c8621e8a51f15 in PR branch system-test-pull-agent with baseline commit 2d067977e970ee680e255902a64d8d0e36e99040 in branch master.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 257 metrics, 9 unstable metrics.
![pr-commenter[bot] avatar](https://avatars.githubusercontent.com/u/365230?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rochdev is this something you would like to still look into? I do think it makes sense to not have to built the agent on our own, but I didn't check how long that currently takes either.
is this something you would like to still look into? I do think it makes sense to not have to built the agent on our own, but I didn't check how long that currently takes either.
Yes this is still something I think we should do. I think this might even be possible in system tests themselves at this point because adding ca-certificates is no longer needed.
@cbeauchesne Thoughts on this?
As we do not install anymore ca-certificates, this changes should make no difference, the current build step pull the base image (which you also do), and run a basic set of docker command that does not rely on any external call, so it's less than 1s.
Furthermore, ghcr.io/datadog/system-tests/docker/agent:latest is produced by the non-official docker mode, so we do not closely check it works fine, so I do not recommend using it.
Thanks for the update @cbeauchesne! With that in mind, I'll go ahead and close this as it seems to not be an issue with the current setup. Please feel free to open a new PR, if you think we should still change the current setup.