Brian Edward Marré

Results 35 issues of Brian Edward Marré

We only document the existence and usage of the moving window feature and parameters inside example cfgs and the PICMI configuration documentation. This should be fixed and a separate entry...

documentation

The moving window configuration via PICMI introduced in #4987 is missing a runtime test. A runtime test is necessary since moving window is a runtime only option and therefore this...

component: tests
good first issue
PICMI

Both the PIConGPU PICMI interface and PyPIConGPU use relative imports, which mean when we import pypicongpu stuff from PICMI we need to traverse a lot of directory levels leading to...

refactoring
good first issue
PICMI

Currently species constants are stored in a list in PyPIConGPU, but semantically they more resemble elements of a set since constant types are supposed to be unique for a species....

refactoring
good first issue
PICMI

PICMI and PyPIConGPU ``__init__.py`` files specify an ``__all__`` variable that is supposed to overwrite the default behavior of ``from picongpu.picmi import *``, but do not actually diverge from the default...

refactoring
good first issue
PICMI

The introduction to using PICMI with PIConGPU contains the relatively long LWFA example as a wall of text lacking a detailed explanation. The example should be moved to a separate...

documentation
refactoring
good first issue
PICMI

as discussed [here](https://github.com/ComputationalRadiationPhysics/picongpu/pull/5007#discussion_r1709314530) the PyPIConGPU implementation of interaction use quite verbose code for getting the dependents, this should be refactored some time in the future.

refactoring
good first issue
PICMI

moves the atomicConfigNumber unit test of FLYonPIC from it's custom location to the standard unit test folder of PIConGPU and makes it part of the the unit test suite of...

refactoring
component: tests

The FLYonPIC(AtomicPhysics) rate calculation unit test requires a pmacc-Buffer mock up, since the rate calculation methods are handling dataBoxes directly. This does not exist and prevents the testing the FLYonPIC(AtomicPhysics)...

Field ionization rates in AtomicPhysics(FLYonPIC) do not reduce with consecutive sub-steps since we do not update the local field yet. These high rates require a large number o atomicPhyiscs sub...

component: core
refactoring