Boshen
Boshen
This is an unsupported / incorrect monorepo setup for reading from source files. You are resolving `@shared/bar` inside `rolldown-path-aliases/shared` using `rolldown-path-aliases/api/tsconfig.json`. `rolldown-path-aliases/api/tsconfig.json` shows `"baseUrl": "."`. This indicates `paths` will only...
We can use https://crates.io/crates/constcat and keep them as const strs.
Waiting for @rzvxa to take a look.
Using `impl for &TraverseCtx: AllocatorAccessor` is not implemented for `&mut TraverseCtx` is not implemented for `&mut TraverseCtx` = note: `AllocatorAccessor`, but not for `&mut TraverseCtx>(&mut self, allocator_accessor: A) -> Self...
https://github.com/eslint/eslint-scope/blob/8082caa1a0f9aae0894a0a01fef9efa7a5e509f6/lib/scope.js#L671
> I found out how TypeScript handles `arguments`. `TypeScript` adds an `arguments` symbol but does not add it in scopes. https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/utilities.ts#L11361-L11380 Nice find. I also see tsc defines ``` globals:...
For the record, I added this to the mangler https://github.com/oxc-project/oxc/blob/0a2f68756f38f8ef003425e856061502b0c97a0a/crates/oxc_mangler/src/lib.rs#L229-L231
Reminder: https://github.com/oxc-project/oxc/issues/8628 - [ ] reenable file https://github.com/oxc-project/monitor-oxc/commit/28c3d1a7eb949e617b94f7fd33dccfc42e24b604 - [ ] add a hard error when stage 3 decorator is encountered.
### Merge activity * **Oct 29, 11:30 PM EDT**: The merge label '0-merge' was detected. This PR will be added to the [Graphite merge queue](https://app.graphite.dev/merges?org=oxc-project&repo=oxc) once it meets the requirements....
Going through Rolldown's `SideEffectDetector` and Rollup's treeshake configuration, oxc's side effect detector should also include * https://rollupjs.org/configuration-options/#treeshake-manualpurefunctions * https://rollupjs.org/configuration-options/#treeshake-unknownglobalsideeffects So we can eventually merge the two implementations and provide a...