Boshen

Results 565 comments of Boshen

We need to ignore it in IDE as well, or actually fix the root cause. The root cause is the fixer need to be offset by the tag position.

```diff diff --git a/crates/rolldown_binding/src/lib.rs b/crates/rolldown_binding/src/lib.rs index dcb2203a3..ea836d80e 100644 --- a/crates/rolldown_binding/src/lib.rs +++ b/crates/rolldown_binding/src/lib.rs @@ -30,6 +30,35 @@ mod generated; pub mod watcher; pub mod worker_manager; +#[cfg(not(target_family = "wasm"))] +#[napi_derive::module_init] +pub fn...

We haven't optimized anything yet, only the env `ROLLDOWN_MAX_BLOCKING_THREADS` is added for testing purposes.

> Do you want to send a PR? I can give it a try next week. Let's also wait for a response from the TypeScript team.

I don't think I can patch these two ESM problems (this issue and #399). The current implementation is not following the ESM specification, resulting conflicting behaviors or major breaking changes...

We had this code before I think, we can copy some of it back.

> > We had this code before I think, we can copy some of it back. > > yeah, #996, why we remove these code? Mostly because I wasn't satisfied...

### Merge activity * **Apr 29, 11:54 AM EDT**: The merge label '0-merge' was detected. This PR will be added to the [Graphite merge queue](https://app.graphite.dev/merges?org=oxc-project&repo=oxc) once it meets the requirements....