Ben Lee

Results 103 comments of Ben Lee

@daohu527 if you are trying to reference a local repository then you want to use https://docs.bazel.build/versions/main/be/workspace.html#local_repository otherwise `urls` needs to be an actual URL that http_archive can download from. Ex:...

Tested this against our repository. Will need to do some more testing but this seems to work except for the unused import check, which seems to just be flagging all...

This should be ready to merge but we found that some of the checks that we rely on right now aren't working with type resolution enabled, which might cause some...

Looks good to me. You'll need to regenerate the docs for this PR to pass CI and get merged.

> Thanks for the reminder 🙇🏼 > > All the remaining red is unique to last green builds. Deleting the native implementation of `aar_import` will definitely break some builds https://github.com/bazelbuild/bazel/commit/947c72d699321c97518dbebe0e8ca59621b5da21

I could be wrong but I _think_ this is a WORKSPACE error and not a Bzlmod error. At least I'm yet to see this one from Bzlmod. Do you have...

@pswaminathan is this one fixed for you with https://github.com/bazelbuild/rules_kotlin/pull/1122 and if so can we close out this issue?

@arunkumar9t2 PR looks good to me as long as you can take care of the RBE case.

@restingbull there is another PR up for this https://github.com/bazelbuild/rules_kotlin/pull/1143 that's probably a bit better.

@jbarr21 Kotlin 2.0 is officially out, are you able to push this PR forward using the official release?