bazel_rules_detekt icon indicating copy to clipboard operation
bazel_rules_detekt copied to clipboard

Support experimental Detekt type resolution

Open Bencodes opened this issue 4 years ago • 4 comments

https://github.com/buildfoundation/bazel_rules_detekt/issues/92

Bencodes avatar Oct 25 '21 18:10 Bencodes

Tested this against our repository. Will need to do some more testing but this seems to work except for the unused import check, which seems to just be flagging all imports as unused when type resolution is enabled.

Bencodes avatar Oct 25 '21 22:10 Bencodes

This is great, @Bencodes! We (At Uber) are also looking for similar support. Are there any timelines to merge the changes?

uKetki avatar Nov 11 '21 13:11 uKetki

This should be ready to merge but we found that some of the checks that we rely on right now aren't working with type resolution enabled, which might cause some confusion when opting in to this.

@arturdryomov any thoughts on when might be the best time to merge this? We can cut a new release but include a disclaimer about experimental_type_resolution no being stable until the next major Detekt release.

Bencodes avatar Nov 11 '21 18:11 Bencodes

@Bencodes, are we talking about built-in checks or internal custom ones? Is there an upstream Detekt issue we can track?

arturdryomov avatar Nov 11 '21 18:11 arturdryomov