Ben Lee

Results 103 comments of Ben Lee

@meteorcloudy I believe @restingbull is looking into this one for you.

Assuming this is not the intended behavior, replacing the `JavaInfo#compile_jars` with just the [direct outputs](https://bazel.build/versions/6.0.0/rules/lib/JavaInfo#java_outputs) will likely be a breaking change for some people and need to be feature flagged...

We should probably cut a new release of `rules_kotlin` before we land this PR so that there's something stable out there in case this has bugs.

@rockwotj are you able to take a look at fixing up the jdeps plugin so that it supports K2?

Found another case where coursier incorrectly pulls the wrong artifact type https://github.com/bazelbuild/rules_jvm_external/issues/1057

@ted-xie are you open to accepting this PR again since the original approach that made this behavior the default got reverted?

https://github.com/bazelbuild/rules_android/pull/130

Some refactoring will need to be done but something like this would add some flexibility: ``` java_binary( name = "r8", main_class = "com.android.tools.r8.R8", visibility = ["//visibility:public"], jvm_flags = ["-Xmx8G", "-XX:ThreadStackSize=2048",...

There's some discussion in the Bazel slack community about this as well. https://bazelbuild.slack.com/archives/CA31HN1T3/p1643720300781339

> So coincidentally I'm about to add another dependency to maven_install (com.android.tools.build:gradle:8.0.1 for R8 integration) which has a number of transitive dependencies, so in the end I think we'll need...