Ben Lee

Results 103 comments of Ben Lee

https://github.com/bazelbuild/rules_kotlin/pull/1117

Support for this will be in the next release.

I'm not super familiar with how listed jdeps are expected to be formatted but [Bazel core](https://github.com/bazelbuild/bazel) also has absolute paths listed. ``` ➜ cat bazel-bin/src/main/java/com/google/devtools/build/lib/server/libserver.jdeps x tbazel-out/darwin_arm64-fastbuild/bin/src/main/java/com/google/devtools/build/lib/server/libpid_file_watcher-hjar.jar r nbazel-out/darwin_arm64-fastbuild/bin/src/main/java/com/google/devtools/build/lib/server/librpc_server-hjar.jar v...

@arunkumar9t2 this seems worth upstreaming to future proof jdeps from regressions like these in the future.

I just verified that this is still working for us in our codebase for both JVM and Android targets using the following command: ``` ➜ bazel test //instant-processors/skabbard-ksp/compiler:test --collect_code_coverage --instrument_test_targets=false...

Some more discussion on this topic happened over here that everyone might find useful https://bazelbuild.slack.com/archives/CE6AZ22NR/p1677512521618239

@pswaminathan are you able to look into these failures?

Prototype has been pushed but we are waiting for a few pull requests in rules_android to land. https://github.com/bazelbuild/rules_kotlin/pull/868

@tdibattista It's getting closer to being ready but there are still a hand full of PRs that we'd like to see get merged before we move over to the Starlark...