Ben Lee

Results 103 comments of Ben Lee

We worked up a solution for making it easier for us to cut releases in the future that uses Github Actions https://github.com/bazelbuild/rules_kotlin/pull/742 We can trigger this as frequently as we...

This is the PR that fixed it https://github.com/JetBrains/kotlin/pull/3986 and the related tickets are https://youtrack.jetbrains.com/issue/KT-40133, https://youtrack.jetbrains.com/issue/KT-41381, and https://youtrack.jetbrains.com/issue/KT-40340.

@oliviernotteghem we can land this PR after 1.6 has it's first stable release, which would put this in the 1.7 release.

Alright was chatting with @nkoroste and @cgruber about how to best merge this. The main concern that we still support Kotlin 1.6 which has version of `kotlin-abi-gen` that are completely...

Thanks for the PR @aeremin! Are you able to add a test case to `KotlinBuilderJvmJdepsTest` for receiver parameter type?

> it will only work if receiver parameter's this is explicitly referenced This might be a test case worth adding as well if it potentially changes how jdeps are interpreted....

@aeremin just landed this. Thanks for the contribution!

@aryeh-looker what's the actual error being shown here when you hover over the red? Is it just complaining that the types aren't available?

> I know rules_kotlin won't automatically get that fix because it don't currently draw on java_import in the implementation of kt_jvm_import, presumably because java_import was broken for Kotlin (https://github.com/bazelbuild/bazel/issues/4549). Thanks...

@restingbull I ran some tests in our codebase with the worker java implementation and wasn't able to reproduce the issue. I was however able to reproduce it almost instantly switching...