rules_kotlin icon indicating copy to clipboard operation
rules_kotlin copied to clipboard

Published 20 hours ago • verified publisher icon bazelbuild

Pass through kotlinc options to JS compile

Open pswaminathan opened this issue 1 year ago • 3 comments

Fixes #1016

I haven't yet considered what options may need to be e.g. stripped out before sending along. But if there are other glaring holes in this, or reasons to avoid this kind of approach altogether, LMK.

pswaminathan avatar Aug 22 '23 02:08 pswaminathan

@pswaminathan it fails on CI: https://buildkite.com/bazel/rules-kotlin-kotlin/builds/3519#018a1b24-c95a-4722-bc75-59b655a3e724

agluszak avatar Aug 28 '23 15:08 agluszak

@pswaminathan are you able to look into these failures?

Bencodes avatar Sep 08 '23 20:09 Bencodes

Yep! Will take a look.

pswaminathan avatar Sep 08 '23 21:09 pswaminathan

I know the tests don't have any JS examples running, so those aren't representative of this working. But the example fail-case I gave in the linked issue does work with this build. I can add that under e.g. examples/kmp/trivial here as an stdlib-only working test case for the JS rules. WDYT?

pswaminathan avatar Apr 01 '24 19:04 pswaminathan