eclipse-platform
Fix- Background color for gutter line in editor
Implementing fix for gutter line background change in dark theme for Win and Mac. Ref 4th issue reported in https://github.com/eclipse-platform/eclipse.platform.ui/issues/2114#issue-2418424128
Was able to fix only this part (strip next to vertical scroll bar) of the editor. Unable to change the gutter line background. It works when I change via CSS spy but not via css file. Any suggestions on this ?
Implementing fix for gutter line background change in dark theme for Win and Mac. Ref 4th issue reported in #2114 (comment)
I don't see a difference. Do I overlook something? You pls. highlight the areas that have changed in the before and after image?
Was able to fix only this part (strip next to vertical scroll bar) of the editor. Unable to change the gutter line background. It works when I change via CSS spy but not via css file. Any suggestions on this ?
What did you add in the CSS spy and how does it look before and after that change in CSS spy?
Test Results
1 210 files - 605 1 210 suites - 605 52m 31s :stopwatch: - 44m 28s 7 684 tests ± 0 7 456 :white_check_mark: + 2 228 :zzz: ± 0 0 :x: - 2 16 142 runs - 8 071 15 673 :white_check_mark: - 7 789 469 :zzz: - 280 0 :x: - 2
Results for commit 2fb2f80a. ± Comparison against base commit a547aa48.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I don't see a difference. Do I overlook something? You pls. highlight the areas that have changed in the before and after image?
Was able to fix only this part (strip next to vertical scroll bar) of the editor. Unable to change the gutter line background. It works when I change via CSS spy but not via css file. Any suggestions on this ?
What did you add in the CSS spy and how does it look before and after that change in CSS spy?
Updated screen shots for both
ok now I get it.
Can you pls. also explain what exactly you did change in the CSS spy? For me that's not so clear from your screenshot.
Can you pls. also explain what exactly you did change in the CSS spy? For me that's not so clear from your screenshot.
Changed the background color of composite (CSS ID - org-eclipse-e4-ui-compatibility-editor) from #2f2f2f to #1E1F22 (background color of text editor)
Can you pls. also explain what exactly you did change in the CSS spy? For me that's not so clear from your screenshot.
Changed the background color of composite (CSS ID - org-eclipse-e4-ui-compatibility-editor) from #2f2f2f to #1E1F22 (background color of text editor)
@vogella: Can you help @mvm-sap with this?
This is replaced by https://github.com/eclipse-platform/eclipse.platform.ui/pull/2744/