Fabien Salathe comments

Results 128 comments of


                                            Fabien Salathe

fix PHP 8.2 warning in CachingTypeFactory

@afk11 @sisou @rubensayshi Would it be possible to merge this fix?

v0.3.0 missing binaries

I was also confused about this, I didn't find binaries for version 0.3.2

Feature request: include/exclude paths to handle glob

Allowing the regex would cover this, otherwise we could simply use the glob function (https://www.php.net/manual/en/function.glob.php).

Question: is it possible to use this library on php 8.1?

This library is not maintained anymore, we did of fork if you want modern PHP compatibility: https://github.com/ProtonMail/bitcoin-php

Show Layer-Tap/Mod-Tap information on keys

Updated the design and made it work with mode-tap too

Show Layer-Tap/Mod-Tap information on keys

Added indicators and some fine tuning

Show Layer-Tap/Mod-Tap information on keys

I wish sorry, I pinged the devs a few times on Discord, I don't know what to do to get it reviewed again/merged. I lost motivation.

Show Layer-Tap/Mod-Tap information on keys

Is there still hope to help me review/merge this MR?

Show Layer-Tap/Mod-Tap information on keys

Ok, thank you guys for the quick answers, I'll try to update this PR one of those days and make it more simple.

Show Layer-Tap/Mod-Tap information on keys

Still a WIP but it's now closer to the behavior param picker What would be good, I think, is to send the behavior name in the protocol. Currently, we don't...