Fabien Salathe

Results 110 comments of Fabien Salathe

Some new UX bundles are also using the `src/` folder (eg. https://github.com/symfony/ux/tree/2.x/src/Autocomplete) and some not (eg. https://github.com/symfony/ux/tree/2.x/src/Chartjs). I'm not sure why it's not consistent across the same repo.

I created an issue to track this @weaverryan. And I didn't realized but the docs got updated 4 months ago in https://github.com/symfony/symfony-docs/pull/16801, both pages now use `src/` for the logic!...

Note: it's possible to do ```yaml nelmio_api_doc: documentation: x: logo: url: 'https://....png' altText: Petstore logo ... ``` I don't know what you prefer, in any case it would be good...

@afk11 is there any plan to merge this soon?

`^2.0` doesn't force PHP^7, `2.0` does, which is the issue with the current composer file. Would it be possible to update ? It's not a breaking change.

If it can help, we did fork it to make it PHP 8 compatible: https://github.com/ProtonMail/bitcoin-php

> The composer.json doesn't seem to be update to PHP8.0. What am I missing? Here is the commit to make it PHP 8.0 compatible: https://github.com/ProtonMail/bitcoin-php/commit/b6ec4d2b4c5fce8a7a1ee124e63c02248fa90c04#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

@afk11 would it be possible to merge this PR ? It's our last blocker to upgrade to PHP 8

We had to fork; https://github.com/ProtonMail/bitcoin-php and `protonlabs/bitcoin` on packagist

If it can help we maintain a fork with PHP8.0+ compatibility: https://github.com/ProtonMail/bitcoin-php