Fabien Salathe

Results 109 comments of Fabien Salathe
trafficstars

@gsherwood any chance? Is there someone else I could ping? Could we add more contributor to the project potentially?

@gsherwood it would be great to have some feedback or more contributors to the project, do you have any plan?

@gsherwood could you help me to merge it?

I was trying to use a custom configuration. For the moment it's hardcoded directly so there is no way to change this programmatically. The best would be to use dependency...

Because we have a tool to get the code quality from a web interface and it doesn't use the default options. For example we want the colors and the report...

Thanks for your answer, but where do you pass this array? In the example I used fixed values but it could be dynamic too (from $_GET for example). If there...

I did another PR to use injection: https://github.com/squizlabs/PHP_CodeSniffer/pull/3882

> @BafS You don't. As I said above, you save it as a `CodeSniffer.conf` file (in the PHPCS directory). The PHPCS `Config` class automatically looks for it and will use...

For information PHPStan was added (I personally prefer Psalm a bit more), I'm not sure it makes sens to have both, the overlap is big. https://github.com/symfony/demo/pull/1391

Related PR: https://github.com/unknown-horizons/godot-port/pull/103