Sam Atkins

Results 398 comments of Sam Atkins

Thanks! So it's related to shadow roots by the look of it.

Hmm, I'm trying to debug this today and it's no longer crashing. I had a look back and it seems like f61df9d34cb fixed it. Before that, it crashes. With that...

It's currently skipped, but this should also fix a bunch of issues in `/css/cssom/serialize-values.html` and maybe some other serialization tests too.

Drafting this until https://github.com/whatwg/html/pull/11284 is merged.

> is there a commit or pr that would be a good example of whats is trying to be achieved here? Not really. I wrote a little explanation here: https://github.com/LadybirdBrowser/ladybird/pull/3663#issuecomment-2687524925...

I made some wrong assumptions while making this issue. 😅 I just tried doing this myself, as it's clearly not appropriate as a good first issue. And it turns out...

My guess is somehow that font doesn't have a bold variant, or Ladybird isn't finding it... We need better font debugging tools.

Ahhhh. Yes, we don't yet support variable width fonts (or, the variable width part anyway). So that all makes sense.

> Just FYI I'm working on adding support for Solaris/illumos to vcpkg for the express purpose of getting this to work again (although I'm testing with a toolchain built with...