ladybird
ladybird copied to clipboard
LadybirdBrowser
Add `noopener-allow-popups` value to Opener Policy
Spec change is here: https://github.com/whatwg/html/pull/10394, which updates this page of the HTML spec.
Hi, this is my first foray into open source contribution. Is this issue still open? If so, can I work on it?
Hi, this is my first foray into open source contribution. Is this issue still open? If so, can I work on it?
It is still open (literally), even though part of it has been implemented. Note that the person who did that also said they are working on the rest of that implementation, so it might not be the best issue to start working on right now, given that someone already seems to be doing it.
That's generally the main thing to look out for when choosing which issue to tackle. (other things to pay attention to might be how complex the issue is and if there's any debate over how/if it should actually be implemented, but that is quite rare)
@Psychpsyo Thank you for your real eye-opening advice!! I'll keep this in mind! :)
is there a commit or pr that would be a good example of whats is trying to be achieved here?
is there a commit or pr that would be a good example of whats is trying to be achieved here?
Not really. I wrote a little explanation here: https://github.com/LadybirdBrowser/ladybird/pull/3663#issuecomment-2687524925
Basically: look at the spec PR, see what changed, and make those changes in our code.
is there a commit or pr that would be a good example of whats is trying to be achieved here?
Not really. I wrote a little explanation here: #3663 (comment)
Basically: look at the spec PR, see what changed, and make those changes in our code.
greping for #matching-coop in ladybird does not return anything. my exact command below.
grep -r "#matching-coop" .
command does work for "#cross-origin-opener-policy". which is just another id close to #matching-coop.
grep -r "#cross-origin-opener-policy" .
returns as i expected
./Libraries/LibWeb/HTML/CrossOrigin/OpenerPolicy.h:// https://html.spec.whatwg.org/multipage/origin.html#cross-origin-opener-policy-value
./Libraries/LibWeb/HTML/CrossOrigin/OpenerPolicy.h:// https://html.spec.whatwg.org/multipage/origin.html#cross-origin-opener-policy
i cant find #matching-coop hence the confusion on what needs to change. @AtkinsSJ
I made some wrong assumptions while making this issue. 😅
I just tried doing this myself, as it's clearly not appropriate as a good first issue. And it turns out that the changes are all in algorithms that we don't implement. So there's nothing specifically to do here. Oops.
Pinging @alicelee2735 in case you were also looking into this.
I made some wrong assumptions while making this issue. 😅
I just tried doing this myself, as it's clearly not appropriate as a good first issue. And it turns out that the changes are all in algorithms that we don't implement. So there's nothing specifically to do here. Oops.
Pinging @alicelee2735 in case you were also looking into this.
@AtkinsSJ Thanks for the ping and the update! Since there's nothing to do now, I'll keep an eye out for other good first issues.
