Sam Atkins

Results 362 comments of Sam Atkins

@06needhamt are you ok to make that last change? Would be a huge shame to let stalebot close this.

> @AtkinsSJ Sorry I've been really busy and I forgot about this. Should hopefully have time this weekend. Will this comment stop it from being closed? No problem! Yeah, any...

Alternatively to having a custom Error type, you could remove the `String::format()` part, and output the extra information in `dbgln()`.

(Only change is what Andrew suggested, I forgot to rebase separately from making code changes.)

> > I'm still a bit iffy on replacing individual spec-based implementations with a single one. > > I get that, are you more worried about the supported format or...

Replaced all but one use of `ByteBuffer::create_uninitialized()` with an `Array`. The remaining one is >32K so that felt a bit large for the stack. But maybe I'm worrying unnecessarily about...

Since last time: - Fixed the merge request - Fixed `cksum` trying to `stat()` stdin Apparently Buggie still doesn't like `w` as a category name. :thonk:

> I merged a separate `checksum` PR that has conflicts w/your changes :) Thanks! They already ported it to Core::Stream so I've dropped my commit that did that. No other...

Oh also, please click the "Resolve conversation" button on any review comments that you have dealt with. It makes it easier for maintainers to spot that they should review the...