serenity
serenity copied to clipboard
SerenityOS
Add a basic .tga file loader to LibGfx
This pull request adds a basic .tga file loader to LibGfx. Currently it can only handle Uncompressed BGR files with a bit depth of 24 and 32 bits per pixel. This is also my first major contribution to SerenityOS with the aim of getting familiar with the API structure. So all comments are welcome
Hello!
One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.
@AtkinsSJ Thank you for the review. I have addressed all of your comments
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
@06needhamt are you ok to make that last change? Would be a huge shame to let stalebot close this.
@AtkinsSJ Sorry I've been really busy and I forgot about this. Should hopefully have time this weekend. Will this comment stop it from being closed?
@AtkinsSJ Sorry I've been really busy and I forgot about this. Should hopefully have time this weekend. Will this comment stop it from being closed?
No problem! Yeah, any comments will scare Stalebot away for another few weeks.
@06needhamt are you ok to make that last change? Would be a huge shame to let stalebot close this.
@AtkinsSJ I have finally gotten around to making the requested change along with some validation after reading the header.
Alternatively to having a custom Error type, you could remove the String::format() part, and output the extra information in dbgln().
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!
This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!