serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Published 20 hours ago • verified publisher icon SerenityOS

Utilities: Port *most* utilities to Core::Stream

Open AtkinsSJ opened this issue 3 years ago • 6 comments

This is a first go to get the majority of simple (and less simple) cases done, leaving the ones that had me scratching my head for a while.

AtkinsSJ avatar Sep 14 '22 16:09 AtkinsSJ

Replaced all but one use of ByteBuffer::create_uninitialized() with an Array<>. The remaining one is >32K so that felt a bit large for the stack. But maybe I'm worrying unnecessarily about that.

Also, using PAGE_SIZE as suggested.

AtkinsSJ avatar Sep 20 '22 11:09 AtkinsSJ

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Oct 11 '22 21:10 stale[bot]

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

BuggieBot avatar Oct 12 '22 13:10 BuggieBot

Since last time:

  • Fixed the merge request
  • Fixed cksum trying to stat() stdin

Apparently Buggie still doesn't like w as a category name. :thonk:

AtkinsSJ avatar Oct 12 '22 13:10 AtkinsSJ

I merged a separate checksum PR that has conflicts w/your changes :)

ADKaster avatar Oct 12 '22 18:10 ADKaster

I merged a separate checksum PR that has conflicts w/your changes :)

Thanks! They already ported it to Core::Stream so I've dropped my commit that did that. No other changes, apart from rebasing.

AtkinsSJ avatar Oct 13 '22 11:10 AtkinsSJ

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Nov 15 '22 02:11 stale[bot]

Since last time:

  • Rebase to to fix conflicts.
  • Fix issues found by davidot.
  • Fix that I'd changed strace to default to stdout instead of stderr.
  • Use std_input() helper in copy.

I've also done some quick and dirty manual testing to make sure everything still works. At least, as best as I could. :sweat_smile:

AtkinsSJ avatar Nov 18 '22 13:11 AtkinsSJ

Changes: Fixed a conflict, which was just that Andreas removed an outln() from lsirq, so this should still be good to go!

AtkinsSJ avatar Nov 19 '22 16:11 AtkinsSJ