use datoshi as the name of the smallest unit of GAS

[Jim8y]

Description

It is ambiguous to call both the smallest unit of GAS and GAS as GAS, thus i had started a discussion and vote in neo discord, and get a name of datoshi for the smallest unit of GAS. This name has being approved by NF. Thus having this pr.

Fixes # (issue)

Type of change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

Test Configuration:

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged and published in downstream modules

[Jim8y]

Datoshi is the name for the smallest unit of GAS.

1 datoshi = 1e-8 GAS 1 kdatoshi = 1e-5 GAS 1 mdatoshi = 1e-2 GAS

Or

1_00_000_000 datoshi = 1_00_000 kdatoshi = 1_00 mdatoshi = 1 GAS

[Jim8y]

what is this new datoshi thing? Just gas?

Yes, just give the smallest unit of GAS a name, cause people including our own are miss using GAS and the smallest unit of GAS, such as 20 GAS and 20_0000_0000 GAS.

[superboyiii]

Does DA know this :)

[Jim8y]

Does DA know this :)

yes

[shargon]

The problem is GAS not satoshi, isn't it?

[Jim8y]

The problem is GAS not satoshi, isn't it?

@shargon The problem is we dont have a name for the smallest unit of GAS while we are actually use it a lot. And in the core, sometimes we use GAS for GAS, sometimes we use the smallest GAS unit as GAS. Its misused.

[Jim8y]

Its voting result. Fixed8 makes too much change to the existing code. And use 0.xxxGAS is good but will change existing neo-cli, a thing should be avoided in this pr.

[AnnaShaleva]

I think there's a couple of places in the neo-devpack that needs to be updated as far.

[Jim8y]

ready to merge

[shargon]

@Jim8y maybe now with the mono-repo we need more changes, did you check it?

[Jim8y]

I will check it now.