Andrew Kushnir

Results 312 comments of Andrew Kushnir

@alxhub I've updated the API and added a couple tests as we discussed (fixup commit: https://github.com/angular/angular/pull/46761/commits/6159102533dc3f61ba39f0dc5a6d735ccedc2831). Could you please take another look?

[TGP after most recent updates](https://test.corp.google.com/OCL:476815881:BASE:476815928:1664174975160:6f028664).

[One more TGP before the submission](https://test.corp.google.com/OCL:477065069:BASE:477065121:1664250511881:faede2ec).

(linking #8277 here as an additional use-case)

Hi @btakita, Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Could you please provide a minimum repro in a...

Hi @alfaproject, If the same problem happens with Ivy, that might indicate that some dependencies that were used in a constructor of a Component/Directive/NgModule/Pipe, don't have Angular top-level decorators (`@Injectable`,...

@mostafabita thanks for additional changes. It looks like CI is failing for 2 reasons: - one of the commits has a commit message that is not aligned with the guidelines...

@cexbrayat @alan-agius4 we've just discussed this PR during the FW team sync and there are **no** objections to move forward. Thank you.

@JiaLiPassion I took a quick look and it seems like removing `packages/zone.js/lib/browser/define-property.ts` file causes the issue. I see errors in the logs like this: ``` Error: : db is not...

[TGP](https://test.corp.google.com/OCL:476249809:BASE:476251893:1663898815387:27d50c04).