Andrew Kushnir comments

Results 312 comments of


                                            Andrew Kushnir

Server-side running code throws an error if the `provideZoneChangeDetection` is used

> Sure, I’ll make a PR if you don’t mind today. Thank you 👍

docs: fix minor typo in tutorial

This PR was merged into the repository by commit b36ec7a4333e47555cc0f9b06e9853f4c2f08401.

fix(benchpress): correctly report memory usage numbers

This PR was merged into the repository by commit dd850b2ab781f24065550f8a948ced498e0f1e99.

Add doc section for runtime translations in internationalization guide

@TheSlimvReal thanks for the reply in https://github.com/angular/angular/issues/38953#issuecomment-1898913107. It makes sense to have a add a section about runtime translation support, but we'd need to figure out what'd be the minimal...

Add doc section for runtime translations in internationalization guide

@TheSlimvReal thanks for setting up an example, this is very helpful. We are still discussing what would be the best way to expose this information in the docs. I'll keep...

feat(forms): FormArray.at can return undefined

> It believe this will shift to at least v17 ? Yes, I've added it to the `v17-candidates` milestone.

[13.3.x] fix(core): hardening attribute and property binding rules for <iframe> elements

Caretaker note: this PR does not require any presubmits, since this is an LTS-only PR.

[14.2.x] fix(core): hardening attribute and property binding rules for <iframe> elements

Caretaker note: FYI this PR is a cherry-pick of a couple commits that we've landed in the main and 15.0.x branches. No changes were made to the fix itself, I...

docs: nginx.conf file doesn't work if copied directly

@omerhakanbilici thanks for creating the PR. Could you please update the commit message (via `git commit --amend`) to add `docs: ` to the very beginning (so that it passes the...

docs: nginx.conf file doesn't work if copied directly

@omerhakanbilici I've noticed some additional commits in this PR. Could you please merge all commits into one and update the commit message to say `docs: nginx.conf file doesn't work if...