Andrew Kushnir

Results 29 issues of Andrew Kushnir

The `selectedOptions` property is not supported on the `select` elements in Domino based on the definition here: https://github.com/fgnass/domino/blob/12a5f67136a0ac10e3fa1649b8787ba3b309e9a7/lib/htmlelts.js#L959-L979 The `selectedOptions` property is [generally supported in all modern browsers](https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/selectedOptions#browser_compatibility) and it'd...

This commit updates docs extraction logic to avoid requiring the `@ngModule` tag on standalone types, since they don't have to be present in any NgModule. This PR is blocking PR...

action: review
comp: docs-infra
target: patch

This commit annotates a set of symbols exposed by the NgOptimizedImage directive as a public API. ## PR Type What kind of change does this PR introduce? - [x] Feature...

action: review
comp: common
PullApprove: disable
target: feature

The `RootContext` implementation contained a number of fields that were needed to support an experimental `renderComponent` function. The `renderComponent` function was removed, which allows us to cleanup the `RootContext` further....

state: blocked
refactoring
comp: core
target: patch

Currently the template-driven validators logic is a bit inconsistent where some validators use `@Input` getters/setters when in other cases we use `ngOnChanges` lifecycle hook to achieve the same behavior (see...

refactoring
comp: forms
forms: validators
P5

Currently, the `Location` and `LocationStrategy` mocks are added by the Router's testing module (the `RouterTestingModule`). However, the `Location` and `LocationStrategy` abstractions are parts of the `@angular/common` package and can be...

state: WIP
comp: common
target: major

See individual commits. ## PR Type What kind of change does this PR introduce? - [x] Feature ## Does this PR introduce a breaking change? - [x] Yes - [...

feature
action: cleanup
breaking changes
comp: core
target: major
flag: deprecation
action: global presubmit

This commit updates the logic related to the attribute and property binding rules for elements. There is a set of attributes that may affect the behavior of an iframe and...

area: core
target: lts
merge: caretaker note
PullApprove: disable
flag: breaking change

This commit updates the logic related to the attribute and property binding rules for elements. There is a set of attributes that may affect the behavior of an iframe and...

area: core
target: lts
merge: caretaker note
PullApprove: disable
detected: breaking change

This commit updates the logic related to the attribute and property binding rules for elements. There is a set of attributes that may affect the behavior of an iframe and...

area: core
target: patch
merge: caretaker note
PullApprove: disable
detected: breaking change