Andrew Kushnir

Results 312 comments of Andrew Kushnir

This PR is blocked by PR #47024 that updates docs extraction logic to stop requiring an `@ngModule` doc tag on standalone types.

@markostanimirovic thanks for the comment 👍 I think it should be possible to do the `RootContext` cleanup (which is the main goal of this PR) without dropping the `markDirty` function....

@markostanimirovic as a possible replacement option, you can look into using cdRef.markForCheck + custom CD scheduling (potentially using the `requestAnimationFrame`, which was used under the hood in the `markDirty` function)....

@markostanimirovic thanks for the reply. Please let us know once https://github.com/ngrx/platform/pull/3488 lands and the change is released, so that we can proceed with this cleanup.

@markostanimirovic just wanted to check if you plan to land https://github.com/ngrx/platform/pull/3488, so that we can proceed with this cleanup without breaking the library. Thank you.

I've looked at this PR and at https://github.com/angular/universal/pull/2666 once again and I think we may need both eventually :) - page-level information on how this page was generated (added via...

Quick update: we've discussed this topic offline with @CaerusKaru and also had a chat with @alan-agius4 and @jessicajaniuk. My takeaway from the discussions is that we need both application-level annotation...

FYI, the PR that adds support for passing a document reference into the `renderModule` and `renderApplication` functions: #47032.

@dario-piotrowicz thanks for creating this PR. We've reviewed the changes and there are some potential risks related to the extra processing. We'd need to dedicate additional time to dig into...