angular-cli icon indicating copy to clipboard operation
angular-cli copied to clipboard

feat(@schematics/angular): enable error on unknown properties and elements in tests

Open cexbrayat opened this issue 3 years ago • 1 comments

PR Checklist

Please check to confirm your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the new behavior?

These new options have been introduced in Angular v14. The commit enables the options in a new project, as we did when we introduced the destroyAfterOption, with the same long-term goal to have these options enabled by default.

This is similar to #21300 which was done in the past to add destroyAfterOption: true by default.

This was discussed with @AndrewKushnir (who wants to discuss it in the next team sync meeting) and the idea would be to change these options to true by default and add a migration to ease the transition in v16 or later.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

cexbrayat avatar Sep 15 '22 09:09 cexbrayat

@cexbrayat @alan-agius4 we've just discussed this PR during the FW team sync and there are no objections to move forward. Thank you.

AndrewKushnir avatar Sep 15 '22 17:09 AndrewKushnir

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.